This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Add expression within #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
reviewed
Feb 28, 2020
MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/style/expressions/Expression.java
Show resolved
Hide resolved
|
Change country label opacity. |
Chaoba
force-pushed
the
kl-within
branch
2 times, most recently
from
d19bc09 to
52f3d20
Compare
9 tasks
tobrun
approved these changes
Mar 4, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #191
This expression will cause error:
E/Mbgl: {pboxsdk.testapp}[JNI]: Error setting property: text-size [1]: 'within' expression requires valid geojson source that contains polygon geometry type.The error is triggered by
isObjectmethod return false in this line https://github.com/mapbox/mapbox-gl-native/blob/9aefd2f2faf0e66afc263e96e3cff4cc03295e64/src/mbgl/style/expression/within.cpp#L111The geojson passed into core is
{“type”:“Polygon”,“coordinates”:[[[-13.359375,67.6092206],[-14.0625,36.1733569],[43.59375,36.456636],[-13.359375,67.6092206]]]}and @zmiao already confirmed that this geojson could pass glfw test.@mapbox/maps-android any idea about this error?